Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: add appveyor #702

Merged
merged 5 commits into from
Jun 19, 2018
Merged

windows: add appveyor #702

merged 5 commits into from
Jun 19, 2018

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Jun 19, 2018

There are some breaking unit tests, but getting started on this.

@r2d4 r2d4 added area/testing Issues concerning the testing phase of Skaffold platform/windows wip labels Jun 19, 2018
r2d4 added 4 commits June 18, 2018 20:14
windows reports 10644 for 10755 files, so the git commit checksum is different
creating symlinks on windows requires elevated privileges
linux allows removing a file when another process has it open, but windows requires the file to be closed before removing
@r2d4 r2d4 removed the wip label Jun 19, 2018
@r2d4 r2d4 changed the title [wip] windows: add appveyor windows: add appveyor Jun 19, 2018
@r2d4
Copy link
Contributor Author

r2d4 commented Jun 19, 2018

Had to skip two tests since they won't work on windows, details in the commits.

@r2d4
Copy link
Contributor Author

r2d4 commented Jun 19, 2018

Fixes #234

@dgageot dgageot merged commit a2babfd into GoogleContainerTools:master Jun 19, 2018
@dgageot dgageot mentioned this pull request Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues concerning the testing phase of Skaffold platform/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants