Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ko): Do not print image name to stdout #6928

Merged

Commits on Dec 3, 2021

  1. fix(ko): Do not print image name to stdout

    With this change, the `ko` builder no longer prints the image name to
    `stdout` by default.
    
    Originally, this was added to the `ko` builder to mimic the behavior of
    the `ko` CLI. Other Skaffold image builders do not print the image name
    in this way.
    
    The reason this is useful for existing `ko` CLI users is that some
    documented workflows rely on capturing the image name from `stdout`, see
    https://github.com/google/ko/blob/v0.9.3/README.md#build-an-image
    
    After some investigation, the better option seems to be to rely on the
    existing `--quiet` and `--output` Skaffold flags to format the output of
    the image name(s).
    
    This change also updates the `ko` builder documentation to show existing
    `ko` CLI users how to capture the image name by providing an appropriate
    Go template to `--output`.
    
    Fixes: GoogleContainerTools#6835
    Closes: GoogleContainerTools#6836
    Tracking: GoogleContainerTools#6041
    halvards committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    4a34ec7 View commit details
    Browse the repository at this point in the history