Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(debug): Improve Go debugging documentation #6852

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

halvards
Copy link
Contributor

Update explanation of how Go debugging works in Skaffold and add explanations for ko builder users.

Also update links to the VS Code Go extension.

Related: #6843
Tracking: #6041

Update explanation of how Go debugging works in Skaffold and add
explanations for ko builder users.

Also update links to the VS Code Go extension.

Related: GoogleContainerTools#6843
Tracking: GoogleContainerTools#6041
@halvards halvards requested a review from a team as a code owner November 12, 2021 07:16
@google-cla google-cla bot added the cla: yes label Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #6852 (a88ab2f) into main (290280e) will decrease coverage by 1.33%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6852      +/-   ##
==========================================
- Coverage   70.48%   69.15%   -1.34%     
==========================================
  Files         515      547      +32     
  Lines       23150    25064    +1914     
==========================================
+ Hits        16317    17332    +1015     
- Misses       5776     6570     +794     
- Partials     1057     1162     +105     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e26ae3...a88ab2f. Read the comment docs.

@halvards halvards added the kokoro:run runs the kokoro jobs on a PR label Nov 12, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 12, 2021
@tejal29 tejal29 merged commit 2551171 into GoogleContainerTools:main Nov 12, 2021
@halvards halvards deleted the ko-debug-docs-example branch November 13, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants