fix(ko): Display correct tag for sideloaded images #6836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display the expected tag after successfully building a ko image, for both sideloaded and published images. Also handles the `tagPolicy.sha256` scenarios. Fixes: GoogleContainerTools#6835 Tracking: GoogleContainerTools#6041
halvards
force-pushed
the
ko-fix-sideload-tag-output
branch
from
b0da432
to
8033e5a
Compare
Codecov Report
@@ Coverage Diff @@
## main #6836 +/- ##
==========================================
- Coverage 70.48% 69.14% -1.35%
==========================================
Files 515 547 +32
Lines 23150 25036 +1886
==========================================
+ Hits 16317 17310 +993
- Misses 5776 6563 +787
- Partials 1057 1163 +106
Continue to review full report at Codecov.
|
halvards
changed the title
| fmt.Fprintln(out, imageRef.Name()) | ||
|
|
||
| outputRef := ref | ||
| if strings.HasSuffix(ref, ":latest") { |
There was a problem hiding this comment.
So does Ko only do use the digest for :latest?
|
Marking as draft until I have time to get back to this one. I think some tweaks may be needed. |
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Dec 3, 2021
With this change, the `ko` builder no longer prints the image name to `stdout` by default. Originally, this was added to the `ko` builder to mimic the behavior of the `ko` CLI. Other Skaffold image builders do not print the image name in this way. The reason this is useful for existing `ko` CLI users is that some documented workflows rely on capturing the image name from `stdout`, see https://github.com/google/ko/blob/v0.9.3/README.md#build-an-image After some investigation, the better option seems to be to rely on the existing `--quiet` and `--output` Skaffold flags to format the output of the image name(s). This change also updates the `ko` builder documentation to show existing `ko` CLI users how to capture the image name by providing an appropriate Go template to `--output`. Fixes: GoogleContainerTools#6835 Closes: GoogleContainerTools#6836 Tracking: GoogleContainerTools#6041
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Dec 3, 2021
With this change, the `ko` builder no longer prints the image name to `stdout` by default. Originally, this was added to the `ko` builder to mimic the behavior of the `ko` CLI. Other Skaffold image builders do not print the image name in this way. The reason this is useful for existing `ko` CLI users is that some documented workflows rely on capturing the image name from `stdout`, see https://github.com/google/ko/blob/v0.9.3/README.md#build-an-image After some investigation, the better option seems to be to rely on the existing `--quiet` and `--output` Skaffold flags to format the output of the image name(s). This change also updates the `ko` builder documentation to show existing `ko` CLI users how to capture the image name by providing an appropriate Go template to `--output`. Fixes: GoogleContainerTools#6835 Closes: GoogleContainerTools#6836 Tracking: GoogleContainerTools#6041
|
Closing in favor of #6928 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the expected tag after successfully building a ko image, for both sideloaded and published images.
Also handles the
tagPolicy.sha256scenarios.Fixes: #6835
Tracking: #6041