Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: organize event v2 functions #6802

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

MarlonGamez
Copy link
Contributor

Description
Refactors some functions used in the event api v2 into different files. Removes some of the bloat from event.go

@MarlonGamez MarlonGamez requested a review from a team as a code owner November 4, 2021 21:46
@MarlonGamez MarlonGamez requested a review from nkubala November 4, 2021 21:46
@google-cla google-cla bot added the cla: yes label Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #6802 (1efe30e) into main (290280e) will decrease coverage by 1.11%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6802      +/-   ##
==========================================
- Coverage   70.48%   69.36%   -1.12%     
==========================================
  Files         515      542      +27     
  Lines       23150    24590    +1440     
==========================================
+ Hits        16317    17058     +741     
- Misses       5776     6400     +624     
- Partials     1057     1132      +75     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/cmd/lint.go 52.94% <52.94%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.49% <75.00%> (-0.57%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
cmd/skaffold/app/flags/image.go 76.27% <100.00%> (+3.72%) ⬆️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f33db9...1efe30e. Read the comment docs.

@tejal29 tejal29 merged commit 008e267 into GoogleContainerTools:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants