feat: add k8s manifest support to skaffold lint and one sample rule #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
force-pushed
the
fix-6098_k8s-manifests-support-v3
branch
2 times, most recently
from
4bad89b to
428bff0
Compare
Codecov Report
@@ Coverage Diff @@
## main #6795 +/- ##
==========================================
- Coverage 70.48% 69.28% -1.20%
==========================================
Files 515 544 +29
Lines 23150 24823 +1673
==========================================
+ Hits 16317 17199 +882
- Misses 5776 6472 +696
- Partials 1057 1152 +95
Continue to review full report at Codecov.
|
aaron-prindle
force-pushed
the
fix-6098_k8s-manifests-support-v3
branch
from
428bff0 to
f748cee
Compare
tejal29
approved these changes
Nov 9, 2021
pkg/skaffold/lint/k8smanifests.go
Outdated
| for _, pattern := range c.Deploy.KubectlDeploy.Manifests { | ||
| // NOTE: pattern is a pattern that can have wildcards, eg: leeroy-app/kubernetes/* | ||
| if util.IsURL(pattern) { | ||
| log.Entry(ctx).Infof("skaffold lint found url manifest and is skipping lint rules for: %s", pattern) |
There was a problem hiding this comment.
shd we move this to debug instead? Additional log lines to users for default level.
There was a problem hiding this comment.
good point, done
aaron-prindle
force-pushed
the
fix-6098_k8s-manifests-support-v3
branch
from
f748cee to
1b388a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6098, adds k8s manifest support to
skaffold lintand one sample rule:The sample rule has the following output when triggered (note
skaffold lintis run against modified version ofexamples/microserviceshere w/ misconfigurations added to the Dockerfiles, not the actualexamples/microservices):Future work for #6098 includes implementing the top 2 lint rules for k8s manifests on top of the framework in this PR.