Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ko): Simple integration test for ko builder #6788

Merged

Conversation

halvards
Copy link
Contributor

@halvards halvards commented Nov 1, 2021

Description
Programmatic integration test to build and push a container image using the ko builder.

CLI-type end-to-end integration tests will require Skaffold config unmarshalling support for the ko builder.

User-facing changes
In the next release, the ko builder example will be in the examples directory. This change includes notes explaining that the feature is not ready yet.

Tracking: #6041

@halvards halvards requested a review from a team as a code owner November 1, 2021 05:51
@halvards halvards requested a review from gsquared94 November 1, 2021 05:51
@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@halvards halvards force-pushed the ko-builder-integration-test branch from 0e1e231 to 08f6a86 Compare November 1, 2021 06:11
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #6788 (d8a83c4) into main (290280e) will decrease coverage by 0.85%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6788      +/-   ##
==========================================
- Coverage   70.48%   69.62%   -0.86%     
==========================================
  Files         515      536      +21     
  Lines       23150    24417    +1267     
==========================================
+ Hits        16317    17001     +684     
- Misses       5776     6290     +514     
- Partials     1057     1126      +69     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/lint.go 52.94% <52.94%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.49% <75.00%> (-0.57%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
cmd/skaffold/app/flags/image.go 76.27% <100.00%> (+3.72%) ⬆️
cmd/skaffold/app/skaffold.go 85.71% <100.00%> (+1.09%) ⬆️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dbba4...d8a83c4. Read the comment docs.

Programmatic integration test to build and push a container image
using the ko builder.

CLI-type end-to-end integration tests will require Skaffold config
unmarshalling support for the ko builder.

Tracking: GoogleContainerTools#6041
@halvards halvards force-pushed the ko-builder-integration-test branch from 08f6a86 to d8a83c4 Compare November 1, 2021 07:38
@halvards halvards added the kokoro:run runs the kokoro jobs on a PR label Nov 1, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 1, 2021
@tejal29 tejal29 self-assigned this Nov 1, 2021
@briandealwis briandealwis merged commit 93e9a23 into GoogleContainerTools:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants