Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade k3d to latest bugfix-version #6781

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Oct 29, 2021

Description

This PR upgrades k3d to the latest bugfix-version: https://github.com/rancher/k3d/releases/tag/v5.0.3, that includes a fix for k3d-io/k3d#801. To work around this issue is not trivial, so I would suggest to merge this and perform a bugfix-release of the Skaffold image as soon as possible.

@erikgb erikgb requested a review from a team as a code owner October 29, 2021 23:11
@erikgb erikgb requested a review from MarlonGamez October 29, 2021 23:11
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@briandealwis
Copy link
Member

briandealwis commented Oct 30, 2021

Thanks @erikgb — you also need to run make build_deps and commit the results. Sorry, this isn't documented. I'll do this as it requires write permission to our image repo.

Rebuilding the images is not something we normally do outside of a release, but it's something we want to look at.

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #6781 (4769d36) into main (290280e) will decrease coverage by 0.85%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6781      +/-   ##
==========================================
- Coverage   70.48%   69.62%   -0.86%     
==========================================
  Files         515      536      +21     
  Lines       23150    24414    +1264     
==========================================
+ Hits        16317    16999     +682     
- Misses       5776     6291     +515     
- Partials     1057     1124      +67     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/lint.go 52.94% <52.94%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.49% <75.00%> (-0.57%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
cmd/skaffold/app/flags/image.go 76.27% <100.00%> (+3.72%) ⬆️
cmd/skaffold/app/skaffold.go 85.71% <100.00%> (+1.09%) ⬆️
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a78b7...4769d36. Read the comment docs.

@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 30, 2021
@briandealwis
Copy link
Member

@googlebot I consent

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 30, 2021
@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2021
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarlonGamez can you give this a look?

@erikgb
Copy link
Contributor Author

erikgb commented Oct 30, 2021

@googlebot I consent

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@MarlonGamez MarlonGamez merged commit 351de30 into GoogleContainerTools:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants