-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade k3d to latest bugfix-version #6781
Conversation
Rebuilding the images is not something we normally do outside of a release, but it's something we want to look at. |
Codecov Report
@@ Coverage Diff @@
## main #6781 +/- ##
==========================================
- Coverage 70.48% 69.62% -0.86%
==========================================
Files 515 536 +21
Lines 23150 24414 +1264
==========================================
+ Hits 16317 16999 +682
- Misses 5776 6291 +515
- Partials 1057 1124 +67
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
@googlebot I consent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarlonGamez can you give this a look?
@googlebot I consent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Description
This PR upgrades k3d to the latest bugfix-version: https://github.com/rancher/k3d/releases/tag/v5.0.3, that includes a fix for k3d-io/k3d#801. To work around this issue is not trivial, so I would suggest to merge this and perform a bugfix-release of the Skaffold image as soon as possible.