Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unit test for skaffold inspect tests list #6656

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@aaron-prindle aaron-prindle requested a review from a team as a code owner September 30, 2021 20:14
@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@aaron-prindle aaron-prindle requested review from gsquared94 and removed request for MarlonGamez September 30, 2021 20:15
@aaron-prindle aaron-prindle force-pushed the fix-inspect-tests-profile-opts branch from 8a80bee to 6e827d6 Compare September 30, 2021 20:16
@aaron-prindle aaron-prindle changed the title fix unit test for skaffold inspect tests list fix: fix unit test for skaffold inspect tests list Sep 30, 2021
@aaron-prindle aaron-prindle force-pushed the fix-inspect-tests-profile-opts branch from 6e827d6 to 49161ae Compare September 30, 2021 20:19
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #6656 (6e827d6) into main (290280e) will decrease coverage by 0.49%.
The diff coverage is 52.94%.

❗ Current head 6e827d6 differs from pull request most recent head 49161ae. Consider uploading reports for the commit 49161ae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6656      +/-   ##
==========================================
- Coverage   70.48%   69.98%   -0.50%     
==========================================
  Files         515      522       +7     
  Lines       23150    23739     +589     
==========================================
+ Hits        16317    16614     +297     
- Misses       5776     6039     +263     
- Partials     1057     1086      +29     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/build/jib/errors.go 48.93% <50.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
pkg/skaffold/build/docker/docker.go 86.44% <66.66%> (-2.85%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151b8d3...49161ae. Read the comment docs.

@tejal29 tejal29 merged commit 26dc1b8 into GoogleContainerTools:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants