Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename a couple of scripts for consistency #6625

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

MarlonGamez
Copy link
Contributor

Description
This PR changes a couple script names from using _ to using - for consistency with our others.

  • hack/install_golint.shhack/install-golint.sh
  • hack/new_version.shhack/new-version.sh

@MarlonGamez MarlonGamez requested a review from a team as a code owner September 21, 2021 23:58
@MarlonGamez MarlonGamez requested a review from nkubala September 21, 2021 23:58
@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #6625 (794f6f2) into main (290280e) will decrease coverage by 0.34%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6625      +/-   ##
==========================================
- Coverage   70.48%   70.14%   -0.35%     
==========================================
  Files         515      520       +5     
  Lines       23150    23621     +471     
==========================================
+ Hits        16317    16568     +251     
- Misses       5776     5973     +197     
- Partials     1057     1080      +23     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/build/jib/errors.go 48.93% <50.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
pkg/skaffold/build/docker/docker.go 86.44% <66.66%> (-2.85%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e3fa9...794f6f2. Read the comment docs.

@MarlonGamez MarlonGamez changed the title Rename a couple of scripts for consistency refactor: Rename a couple of scripts for consistency Sep 22, 2021
@tejal29 tejal29 merged commit a07019e into GoogleContainerTools:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants