Add image label support to ko builder #6597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6597 +/- ##
==========================================
- Coverage 70.48% 70.09% -0.40%
==========================================
Files 515 520 +5
Lines 23150 23611 +461
==========================================
+ Hits 16317 16549 +232
- Misses 5776 5985 +209
- Partials 1057 1077 +20
Continue to review full report at Codecov.
|
This enables users to label images built by the ko builder, similar to the `LABEL` instruction in `Dockerfile`s. The Open Container Initiative Image Format Specification lists a number of pre-defined annotation (label) keys. Some image registries use these, e.g., GitHub Container Registry: https://docs.github.com/en/packages/learn-github-packages/connecting-a-repository-to-a-package#connecting-a-repository-to-a-container-image-using-the-command-line **Tracking:** GoogleContainerTools#6041
halvards
force-pushed
the
ko-builder-image-labels
branch
from
94c2cdd to
fe497f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables users to label images built by the ko builder, similar to the
LABELinstruction inDockerfiles.The Open Container Initiative Image Format Specification lists a number of pre-defined annotation (label) keys. Some image registries use these, An example is GitHub Container Registry, which uses the
org.opencontainers.image.sourcelabel to connect a Git repository to a container image.Tracking: #6041