Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong link on the custom-tests example, fixes #6591 #6592

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

mururu
Copy link
Contributor

@mururu mururu commented Sep 11, 2021

Fixes: #6591

@mururu mururu requested a review from a team as a code owner September 11, 2021 03:07
@mururu mururu requested a review from nkubala September 11, 2021 03:07
@google-cla google-cla bot added the cla: yes label Sep 11, 2021
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here! LGTM

@aaron-prindle aaron-prindle enabled auto-merge (squash) September 13, 2021 16:56
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #6592 (8cdff4c) into main (290280e) will decrease coverage by 0.08%.
The diff coverage is 54.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6592      +/-   ##
==========================================
- Coverage   70.48%   70.40%   -0.09%     
==========================================
  Files         515      517       +2     
  Lines       23150    23280     +130     
==========================================
+ Hits        16317    16390      +73     
- Misses       5776     5828      +52     
- Partials     1057     1062       +5     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/debug/apply_transforms.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/debug/transform.go 95.91% <ø> (ø)
pkg/skaffold/docker/logger/log.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/kubectl/exec.go 100.00% <ø> (ø)
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/schema/v2beta21/upgrade.go 100.00% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d306e4...8cdff4c. Read the comment docs.

@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label Sep 13, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 13, 2021
@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label Sep 13, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 13, 2021
@aaron-prindle aaron-prindle merged commit 3f95ad5 into GoogleContainerTools:main Sep 13, 2021
@mururu mururu deleted the fix-6591 branch September 14, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong link on custom-tests example
3 participants