fix: treat pod deletion as if its containers were terminated

[briandealwis]

Fixes: #6586

Description

• Treat pod-deletions as equivalent to terminating all containers within the pod.
• Rewrite the debug container-manager tests to test different sequences of events to ensure that we handle container terminations and pod deletions equivalently

[codecov]

Codecov Report

Merging #6587 (cbe631e) into main (290280e) will decrease coverage by 0.19%.
The diff coverage is 53.03%.

@@            Coverage Diff             @@
##             main    #6587      +/-   ##
==========================================
- Coverage   70.48%   70.29%   -0.20%     
==========================================
  Files         515      517       +2     
  Lines       23150    23292     +142     
==========================================
+ Hits        16317    16372      +55     
- Misses       5776     5850      +74     
- Partials     1057     1070      +13     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/flags.go	90.81% <ø> (ø)
cmd/skaffold/skaffold.go	0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go	0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go	0.00% <ø> (-16.67%)	⬇️
pkg/skaffold/config/options.go	100.00% <ø> (ø)
pkg/skaffold/debug/apply_transforms.go	22.64% <0.00%> (-0.44%)	⬇️
pkg/skaffold/debug/transform.go	95.91% <ø> (ø)
pkg/skaffold/docker/logger/log.go	22.64% <0.00%> (-0.44%)	⬇️
pkg/skaffold/kubectl/exec.go	100.00% <ø> (ø)
pkg/skaffold/kubernetes/debugging/transform.go	84.44% <0.00%> (ø)
... and 40 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b296e...cbe631e. Read the comment docs.

[gsquared94]

is this check l.Logger.IsLevelEnabled(logrus.TraceLevel) required? Doesn't l.Trace already handle it? Is it to save the cost of constructing the string?

[briandealwis]

Yeah, probably premature optimization: I thought the podWatcher fired more events than it actually does. This dereferencing seemed a bit distasteful but our output logger just returns a logrus object anyways.

[briandealwis]

pkg/skaffold/kubernetes/watcher.go:25:2: Do not use github.com/sirupsen/logrus package, use output.log.Entry instead 😭

[tejal29]

wait you can add a allowlist of files here hack/tools/linters/logrus.go
Don't let the technology stop you!

// Ignore files
var ignoreFileSuffixes = []string{
        // always ignore test files
        "_test.go",
        "pkg/skaffold/output/log/log.go",
        "pkg/skaffold/event/v2/logger.go",
        "pkg/skaffold/build/buildpacks/logger.go",
}