Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention hooks don't run on cached artifacts #6577

Merged
merged 2 commits into from
Sep 9, 2021
Merged

docs: mention hooks don't run on cached artifacts #6577

merged 2 commits into from
Sep 9, 2021

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Sep 8, 2021

Fixes: #6572
Related: #6572

@ahmetb ahmetb requested a review from a team as a code owner September 8, 2021 17:09
@ahmetb ahmetb requested a review from briandealwis September 8, 2021 17:09
@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Sep 8, 2021
@container-tools-bot
Copy link

Please visit http://34.94.177.206:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 8, 2021
Co-authored-by: Brian de Alwis <[email protected]>
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #6577 (b831f6d) into main (290280e) will decrease coverage by 0.06%.
The diff coverage is 34.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6577      +/-   ##
==========================================
- Coverage   70.48%   70.41%   -0.07%     
==========================================
  Files         515      517       +2     
  Lines       23150    23268     +118     
==========================================
+ Hits        16317    16384      +67     
- Misses       5776     5822      +46     
- Partials     1057     1062       +5     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 70.68% <0.00%> (-0.38%) ⬇️
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/docker/logger/log.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/schema/v2beta21/upgrade.go 100.00% <ø> (ø)
pkg/skaffold/schema/versions.go 85.51% <ø> (ø)
pkg/skaffold/server/server.go 46.87% <0.00%> (-0.75%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af942a...b831f6d. Read the comment docs.

@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Sep 9, 2021
@container-tools-bot
Copy link

Please visit http://35.236.30.3:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 9, 2021
@gsquared94 gsquared94 merged commit 6d306e4 into GoogleContainerTools:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build hooks sometimes don't work
4 participants