Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add "Open in Cloud Shell" link to examples #6514

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

kelsk
Copy link
Contributor

@kelsk kelsk commented Aug 25, 2021

Description

Adding Open in Cloud Shell buttons to all skaffold examples

This allows users to test the examples in Cloud Shell with skaffold pre-installed.

Examples omitted:

  • dev-journey-buildpacks - tutorial.md has OiCS
  • simple-artifact-registry - no README

@kelsk kelsk requested a review from a team as a code owner August 25, 2021 20:39
@kelsk kelsk requested a review from gsquared94 August 25, 2021 20:39
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@kelsk kelsk changed the title [docs] Add "Open in Cloud Shell" link to examples docs: Add "Open in Cloud Shell" link to examples Aug 25, 2021
@gsquared94
Copy link
Contributor

This looks great. Alas the changes need to be made in integration/examples/... and not in examples/...
During release integration/examples get copied over to examples.

@kelsk
Copy link
Contributor Author

kelsk commented Aug 26, 2021

This looks great. Alas the changes need to be made in integration/examples/... and not in examples/...
During release integration/examples get copied over to examples.

@gsquared94 Oops, sorry about that 🤦🏻‍♀️ I'll remember the correct folder to use for future changes!
I've moved the links from examples/.. to integration/examples/...

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #6514 (245bf82) into main (997edc8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6514      +/-   ##
==========================================
+ Coverage   70.43%   70.45%   +0.01%     
==========================================
  Files         515      515              
  Lines       23127    23142      +15     
==========================================
+ Hits        16289    16304      +15     
- Misses       5780     5782       +2     
+ Partials     1058     1056       -2     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/event.go 84.58% <0.00%> (-0.06%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/skaffold/event/v2/build.go 100.00% <0.00%> (ø)
pkg/skaffold/event/v2/deploy.go 100.00% <0.00%> (ø)
pkg/skaffold/event/v2/logger.go 76.27% <0.00%> (ø)
pkg/skaffold/docker/image.go 66.55% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3839f4...245bf82. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks @kelsk

@MarlonGamez MarlonGamez merged commit 3b25f5e into GoogleContainerTools:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants