log: use context.TODO for not yet plumbed ctx #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6462 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 510 510
Lines 22976 22976
=======================================
Hits 16149 16149
Misses 5770 5770
Partials 1057 1057
Continue to review full report at Codecov.
|
|
I think @marlon-gamez is working on refactoring this. |
Replacing context.Background() usage with context.TODO (https://pkg.go.dev/context?utm_source=godoc#TODO) so we can clean up later on more easily. Signed-off-by: Ahmet Alp Balkan <[email protected]>
|
@tejal29 Yeah Marlon is aware of the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6461
Related: #6419
Description
Replacing context.Background() usage with context.TODO
(https://pkg.go.dev/context?utm_source=godoc#TODO) so we can clean up later on
more easily.