Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to support patterns in --user flag #6402

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Add functionality to support patterns in --user flag #6402

merged 3 commits into from
Aug 10, 2021

Conversation

verbanicm
Copy link
Contributor

Fixes: #5827

Description

  • Added pattern matching for --user flag
  • Accepted patterns: ^allowedUser(\/.+)?$ IE: string or string/string
  • Valid Examples: vsc or vsc/staging
  • Invalid Examples: vsc/ vsc|development random-string

@verbanicm verbanicm requested a review from tejal29 August 10, 2021 20:44
@verbanicm verbanicm requested a review from a team as a code owner August 10, 2021 20:44
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@tejal29 tejal29 enabled auto-merge (squash) August 10, 2021 20:46
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #6402 (229c264) into main (10f4672) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6402      +/-   ##
==========================================
+ Coverage   70.36%   70.38%   +0.01%     
==========================================
  Files         499      500       +1     
  Lines       22725    22733       +8     
==========================================
+ Hits        15991    16000       +9     
+ Misses       5691     5689       -2     
- Partials     1043     1044       +1     
Impacted Files Coverage Δ
pkg/skaffold/user/user.go 75.00% <75.00%> (ø)
pkg/skaffold/instrumentation/export.go 64.00% <100.00%> (ø)
pkg/skaffold/version/version.go 100.00% <100.00%> (ø)
pkg/skaffold/log/stream/stream.go 81.25% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f4672...229c264. Read the comment docs.

@tejal29 tejal29 merged commit 280cd65 into GoogleContainerTools:main Aug 10, 2021
@verbanicm verbanicm deleted the user-patterns branch August 11, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pattern matching --user flag.
2 participants