Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: implement kubectl deploy hooks #6376

Merged

Conversation

gsquared94
Copy link
Contributor

Hooks PR 7 of n

Related: #1441, #6147, #6159, #6160, #6163, #6177
Refer to http://tinyurl.com/skaffold-hooks for detailed design
This PR implements deploy stage lifecycle hooks (starting with the kubectl deployer). Try out example integration/lifecycle-hooks.

@gsquared94 gsquared94 requested a review from a team as a code owner August 6, 2021 15:47
@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Aug 6, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Looks good to me. Verified changes locally as well

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #6376 (07f19c5) into main (cf4aab8) will decrease coverage by 0.10%.
The diff coverage is 51.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6376      +/-   ##
==========================================
- Coverage   70.49%   70.38%   -0.11%     
==========================================
  Files         498      499       +1     
  Lines       22560    22722     +162     
==========================================
+ Hits        15903    15994      +91     
- Misses       5627     5685      +58     
- Partials     1030     1043      +13     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/deploy/kubectl/kubectl.go 64.07% <6.66%> (-3.95%) ⬇️
pkg/skaffold/deploy/deploy_mux.go 42.85% <12.50%> (-2.60%) ⬇️
pkg/skaffold/hooks/container.go 52.45% <18.75%> (-11.99%) ⬇️
pkg/skaffold/log/stream/stream.go 81.25% <66.66%> (-4.47%) ⬇️
pkg/skaffold/hooks/deploy.go 85.71% <85.71%> (ø)
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (-14.55%) ⬇️
pkg/skaffold/kubernetes/client/client.go 26.66% <0.00%> (-13.34%) ⬇️
pkg/skaffold/util/port.go 82.50% <0.00%> (-8.55%) ⬇️
pkg/skaffold/kubernetes/context/context.go 76.08% <0.00%> (-3.46%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4aab8...07f19c5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants