Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing additional CLI flags to docker build #6343

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Aug 2, 2021

Fixes: #5638

Description

This change introduces a new config field, build.artifacts.docker.cliFlags, which allows users to send arbitrary flags to the Docker CLI when performing a build. Existing natively-supported flags will be left untouched to preserve backwards compatibility, but we should probably refrain from adding any additional flags via fields in the DockerArtifact type.

@nkubala nkubala requested a review from a team as a code owner August 2, 2021 19:05
@nkubala nkubala requested a review from briandealwis August 2, 2021 19:05
@google-cla google-cla bot added the cla: yes label Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #6343 (e204794) into main (47e12af) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6343      +/-   ##
==========================================
- Coverage   70.45%   70.43%   -0.02%     
==========================================
  Files         498      498              
  Lines       22539    22540       +1     
==========================================
- Hits        15879    15877       -2     
- Misses       5635     5636       +1     
- Partials     1025     1027       +2     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/docker/image.go 65.56% <100.00%> (-0.89%) ⬇️
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/util/tar.go 65.51% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e12af...e204794. Read the comment docs.

@nkubala nkubala enabled auto-merge (squash) August 2, 2021 19:34
@nkubala nkubala merged commit 41388c0 into GoogleContainerTools:main Aug 10, 2021
@nkubala nkubala deleted the docker-flags branch August 11, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional flags for docker build command when using the CLI
2 participants