Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for lifecycle hooks #6330

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Jul 29, 2021

@gsquared94 gsquared94 requested a review from MarlonGamez July 29, 2021 07:28
@gsquared94 gsquared94 requested a review from a team as a code owner July 29, 2021 07:28
@google-cla google-cla bot added the cla: yes label Jul 29, 2021
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Jul 29, 2021
@container-tools-bot
Copy link

Please visit http://35.236.30.3:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #6330 (adde167) into main (1c5e0a8) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6330      +/-   ##
==========================================
- Coverage   70.80%   70.57%   -0.23%     
==========================================
  Files         494      496       +2     
  Lines       22325    22457     +132     
==========================================
+ Hits        15807    15850      +43     
- Misses       5498     5584      +86     
- Partials     1020     1023       +3     
Impacted Files Coverage Δ
pkg/skaffold/docker/tracker/tracker.go 82.75% <0.00%> (-2.54%) ⬇️
pkg/skaffold/docker/image.go 65.44% <0.00%> (-1.11%) ⬇️
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/schema/validation/validation.go 86.24% <0.00%> (-0.66%) ⬇️
pkg/skaffold/event/v2/event.go 84.64% <0.00%> (-0.22%) ⬇️
pkg/skaffold/runner/deployer.go 58.25% <0.00%> (ø)
pkg/skaffold/deploy/docker/deploy.go 0.00% <0.00%> (ø)
pkg/skaffold/schema/latest/v1/config.go 62.16% <0.00%> (ø)
pkg/skaffold/sync/docker.go 71.42% <0.00%> (ø)
pkg/skaffold/deploy/docker/port.go 22.50% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5e0a8...adde167. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Jul 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 29, 2021
@MarlonGamez
Copy link
Contributor

MarlonGamez commented Jul 29, 2021

For some reason when looking at the preview docs there is a bug with the page footer not being at the bottom of the page
Screen Shot 2021-07-29 at 10 28 45 AM

I'm not sure if this is somehow an issue with the PR, but it seems to only happen on the lifecycle hooks page

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just have a couple small questions regarding some lines

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle aaron-prindle mentioned this pull request Jul 29, 2021
@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Jul 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 29, 2021
@gsquared94 gsquared94 enabled auto-merge (squash) July 30, 2021 04:03
@gsquared94 gsquared94 disabled auto-merge July 30, 2021 05:25
@gsquared94 gsquared94 merged commit 407a8db into GoogleContainerTools:main Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants