Remove skaffoldLogs endpoint, consolidate into events endpoint #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
approved these changes
Jul 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #6296 +/- ##
==========================================
+ Coverage 70.80% 70.81% +0.01%
==========================================
Files 494 494
Lines 22331 22319 -12
==========================================
- Hits 15811 15805 -6
+ Misses 5501 5495 -6
Partials 1019 1019
Continue to review full report at Codecov.
|
nkubala
pushed a commit
to nkubala/skaffold
that referenced
this pull request
Jul 27, 2021
…eContainerTools#6296) * remote skaffoldLogs endpoint, consolidate into events endpoint * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5368
Description
At the request of IDE teams, this PR combines the
skaffoldLogsendpoint into theeventsendpoint. This will help with the issue of having to order things on the IDE side.