Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git fetch origin/main before make checks #6274

Merged
merged 2 commits into from
Jul 22, 2021
Merged

git fetch origin/main before make checks #6274

merged 2 commits into from
Jul 22, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Jul 22, 2021

Fixes: #5656

Description
Sets up tracking of origin/main and uses git fetch to make sure we don't run into

FATA[0000] failed running [/usr/bin/git diff --name-only origin/master -- pkg/skaffold/schema]: running [/usr/bin/git diff --name-only origin/main -- pkg/skaffold/schema]
 - stdout: ""
 - stderr: "fatal: bad revision 'origin/main'\n"
 - cause: exit status 128 

@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #6274 (dee631e) into main (533016e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6274      +/-   ##
==========================================
+ Coverage   70.86%   70.87%   +0.01%     
==========================================
  Files         490      490              
  Lines       22162    22162              
==========================================
+ Hits        15704    15708       +4     
+ Misses       5441     5439       -2     
+ Partials     1017     1015       -2     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533016e...dee631e. Read the comment docs.

@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Jul 22, 2021
@MarlonGamez MarlonGamez changed the title [test] git fetch [test] git fetch origin/main before make checks Jul 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 22, 2021
@MarlonGamez MarlonGamez marked this pull request as ready for review July 22, 2021 20:01
@MarlonGamez MarlonGamez requested a review from a team as a code owner July 22, 2021 20:01
@MarlonGamez MarlonGamez requested a review from tejal29 July 22, 2021 20:01
@MarlonGamez MarlonGamez changed the title [test] git fetch origin/main before make checks git fetch origin/main before make checks Jul 22, 2021
@tejal29 tejal29 merged commit 6f7acec into main Jul 22, 2021
@tejal29 tejal29 deleted the fetch-main branch July 22, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hack/check-schema-changes.sh fails on PRs from the same repo
3 participants