Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Fix Workdir error when --filename flag is used. #6247

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[cherry-pick] Fix Workdir error when --filename flag is used. #6247

merged 1 commit into from
Jul 20, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jul 19, 2021

corresponding PR #6245

@yuwenma yuwenma requested a review from tejal29 July 19, 2021 20:35
@yuwenma yuwenma requested a review from a team as a code owner July 19, 2021 20:35
@google-cla google-cla bot added the cla: yes label Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #6247 (7cfce52) into v2 (81608f3) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #6247      +/-   ##
==========================================
- Coverage   69.82%   69.81%   -0.01%     
==========================================
  Files         476      476              
  Lines       21338    21342       +4     
==========================================
+ Hits        14899    14900       +1     
- Misses       5474     5475       +1     
- Partials      965      967       +2
Impacted Files Coverage Δ
pkg/skaffold/runner/runcontext/v2/context.go 77.27% <71.42%> (+0.60%) ⬆️
pkg/skaffold/docker/image.go 80.08% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81608f3...7cfce52. Read the comment docs.

@yuwenma yuwenma mentioned this pull request Jul 20, 2021
Merged
@yuwenma yuwenma requested a review from MarlonGamez July 20, 2021 01:02
@tejal29 tejal29 merged commit a9c1138 into GoogleContainerTools:v2 Jul 20, 2021
yuwenma added a commit that referenced this pull request Jul 20, 2021
@yuwenma
Revert "Fix Workdir error when --filepath flag is used. (#6247)"
379bb95 
This reverts commit a9c1138.
@yuwenma yuwenma mentioned this pull request Jul 20, 2021
Merged
tejal29 pushed a commit that referenced this pull request Jul 21, 2021
@yuwenma
Revert "Fix Workdir error when --filepath flag is used. (#6247)" (#6256)
9058d89 
This reverts commit a9c1138.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@MarlonGamez MarlonGamez Awaiting requested review from MarlonGamez

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuwenma @tejal29