Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switched container/pod names in app log event #6215

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jul 14, 2021

Looks like these somehow got switched without us noticing. This should fix them showing up in reverse in the IDEs.

@nkubala nkubala requested a review from a team as a code owner July 14, 2021 23:01
@nkubala nkubala requested a review from briandealwis July 14, 2021 23:01
@google-cla google-cla bot added the cla: yes label Jul 14, 2021
@nkubala nkubala enabled auto-merge (squash) July 14, 2021 23:01
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #6215 (53bcea7) into master (7453095) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6215      +/-   ##
==========================================
- Coverage   70.84%   70.83%   -0.01%     
==========================================
  Files         490      490              
  Lines       22123    22123              
==========================================
- Hits        15673    15671       -2     
- Misses       5434     5435       +1     
- Partials     1016     1017       +1     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/application_logs.go 100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go 52.87% <0.00%> (-4.60%) ⬇️
pkg/skaffold/docker/parse.go 88.23% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7453095...53bcea7. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should have a more substantial integration test that triggers LogAggregator.streamContainerLogs and verifies the log output event.

@nkubala nkubala merged commit 81394ca into GoogleContainerTools:master Jul 20, 2021
@nkubala nkubala deleted the application-log-event branch July 20, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants