-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added template expansion for helm chart version (#5709) #6157
Conversation
…#5709) Signed-off-by: Pablo Caderno <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6157 +/- ##
==========================================
- Coverage 71.12% 71.09% -0.03%
==========================================
Files 483 483
Lines 21549 21553 +4
==========================================
- Hits 15326 15323 -3
- Misses 5246 5249 +3
- Partials 977 981 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kadern0! I'll make the change I suggested below and added a quick test for verification.
This comment has been minimized.
This comment has been minimized.
@googlebot I consent. |
Thanks :) |
Signed-off-by: Pablo Caderno [email protected]
Fixes: #5709
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
Added template expansion for Helm chart version.
Before (no variable expansion):
After (it uses the value):

If variable is not defined:
