Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6100
Description
In
skaffold debug
, we rewrite container command-lines to run under the applicable language runtime debugger. We support "sh -c"-style command-lines that result from DockerfileRUN command args
by splitting and then re-joining the command-lines. Our re-joining helper tries to do minimal escaping, escaping only whitespace and a double-quote. But command-lines such as [Bank of Anthos'scontacts
] container then fail as they include parentheses, which are interpreted by the shell:This PR causes our re-join to quote parentheses, brackets, and braces, and single-quotes too.
This quoting is imperfect as we don't track information such as the
contacts:create_app()
being quoted.