Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on ko #6042

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

halvards
Copy link
Contributor

Description

Small steps, this is just to verify the impact of changes to the
dependency graph.

Related: #6041

Small steps, this is just to verify the impact of changes to the
dependency graph.

Tracking issue: GoogleContainerTools#6041
@halvards halvards requested a review from a team as a code owner June 18, 2021 08:38
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #6042 (3d5ebb8) into master (e01d089) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6042      +/-   ##
==========================================
- Coverage   70.75%   70.74%   -0.01%     
==========================================
  Files         464      464              
  Lines       17928    17928              
==========================================
- Hits        12685    12684       -1     
  Misses       4313     4313              
- Partials      930      931       +1     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01d089...3d5ebb8. Read the comment docs.

@halvards
Copy link
Contributor Author

I've added a small section in the design proposal to explain the implementation approach of the ko builder. The approach is to implement the ko builder as a series of small PRs that can be merged one-by-one. No user-visible changes will be visible until the feature is ready.

See: #6046

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Jun 21, 2021
@tejal29 tejal29 enabled auto-merge (squash) June 21, 2021 16:32
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 21, 2021
@tejal29
Copy link
Member

tejal29 commented Jun 21, 2021

Looking forward to the ko builder functionality!

@tejal29 tejal29 merged commit 5c3eb41 into GoogleContainerTools:master Jun 21, 2021
@halvards halvards deleted the add-ko-dependency branch June 22, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants