Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more detailed error when unknown Project #5939

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 4, 2021

Fixes #5214

I could not reproduce the original issue since there were no debug or trace logs.

In this PR

  1. Log the original error seen
  2. Return more text from actual error so that users can get more context on what went wrong.

@tejal29 tejal29 requested a review from a team as a code owner June 4, 2021 03:23
@tejal29 tejal29 requested a review from aaron-prindle June 4, 2021 03:23
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #5939 (1aa3ac1) into master (aa9b115) will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5939      +/-   ##
==========================================
+ Coverage   70.66%   70.67%   +0.01%     
==========================================
  Files         454      454              
  Lines       17399    17404       +5     
==========================================
+ Hits        12295    12301       +6     
  Misses       4196     4196              
+ Partials      908      907       -1     
Impacted Files Coverage Δ
pkg/skaffold/build/build_problems.go 93.44% <90.00%> (-1.21%) ⬇️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b115...1aa3ac1. Read the comment docs.

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Jun 4, 2021

Seems there is schema error, doesn't seem to be a flake from first glance. From Travis logs:

FATA[0000] failed running [/usr/bin/git diff --name-only origin/master -- pkg/skaffold/schema]: running [/usr/bin/git diff --name-only origin/master -- pkg/skaffold/schema]
 - stdout: ""
 - stderr: "fatal: bad revision 'origin/master'\n"
 - cause: exit status 128 
exit status 1
FAILED hack/check-schema-changes.sh

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, travis is failing currently but not sure how it is related to the code changes here

@tejal29 tejal29 merged commit 8a1586b into master Jun 4, 2021
@tejal29 tejal29 deleted the fix_project_not_found branch June 4, 2021 20:43
@tejal29
Copy link
Contributor Author

tejal29 commented Jun 4, 2021

LGTM, travis is failing currently but not sure how it is related to the code changes here

yeah. I accidently created a Pr from remote instead of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold emits unhelpful error: Build Failed. Check your GCR project.
2 participants