-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for using kubectl and helm together #586
Basic support for using kubectl and helm together #586
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@ajbouh Would you be able to sign the CLA? |
Done |
@ajbouh Can you please rebase your code? Thanks a lot! |
@ajbouh can you check that you signed the CLA with the right email address? The bot is still saying it's not signed. |
Hmm, I have multiple email addresses in GitHub, but only signed with the
address that's referenced by the commit. Do you think that could be the
issue?
…On Tue, Jun 19, 2018, 09:27 dlorenc ***@***.***> wrote:
@ajbouh <https://github.com/ajbouh> can you check that you signed the CLA
with the right email address? The bot is still saying it's not signed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#586 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAcnRC79Y1mbn90pqrK4pHiPddhlwt-ks5t-SaKgaJpZM4ULL13>
.
|
@ajbouh yes, that can be the issue. Can you also rebase your code, please? Thanks! |
@ajbouh ping, do you still have issues with the CLA/rebasing? |
8f0f0ae
to
2182fc0
Compare
CLAs look good, thanks! |
@balopat rebased. Also, looks like the cla bot doesn't recheck until you repush |
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
- Coverage 40.61% 40.19% -0.43%
==========================================
Files 68 68
Lines 2969 3005 +36
==========================================
+ Hits 1206 1208 +2
- Misses 1639 1671 +32
- Partials 124 126 +2
Continue to review full report at Codecov.
|
This is the minimal change needed to do deploys with both kubectl and helm.
If only one configuration is present, it falls back to existing logic. If both configurations are present, a new deployer is returned that runs both helm and kubectl in sequence.
It is naive in a number of ways:
Addresses #528