Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move profile verification higher up the stack #5779

Merged
merged 2 commits into from
May 5, 2021

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented May 4, 2021

Related: #5707
Implements #5755 (comment)
Description

Currently the profile selection (--profile or -p flag values) is being validated for each config. In #5707 we want to allow specifying profile names that are found in a nested modules layout. So it can't be validated for every file, but rather at the end after all files have been processed.

@gsquared94 gsquared94 requested a review from briandealwis May 4, 2021 04:37
@gsquared94 gsquared94 requested a review from a team as a code owner May 4, 2021 04:37
@google-cla google-cla bot added the cla: yes label May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #5779 (2584d51) into master (d14f34d) will decrease coverage by 0.02%.
The diff coverage is 76.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5779      +/-   ##
==========================================
- Coverage   70.78%   70.76%   -0.03%     
==========================================
  Files         432      433       +1     
  Lines       16242    16278      +36     
==========================================
+ Hits        11497    11519      +22     
- Misses       3901     3910       +9     
- Partials      844      849       +5     
Impacted Files Coverage Δ
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
pkg/skaffold/build/jib/jvm.go 55.55% <55.55%> (ø)
pkg/skaffold/parser/config.go 79.56% <100.00%> (-0.13%) ⬇️
pkg/skaffold/schema/errors/errors.go 100.00% <100.00%> (ø)
pkg/skaffold/schema/profiles.go 88.46% <100.00%> (-1.15%) ⬇️
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a89e8f...2584d51. Read the comment docs.

@gsquared94 gsquared94 merged commit b1fa526 into GoogleContainerTools:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants