Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skaffold inspect profiles command #5778

Merged

Conversation

gsquared94
Copy link
Contributor

Related #5758
Add command skaffold inspect profiles

❯ skaffold inspect profiles                          
Interact with configuration profiles

Available Commands:
  list        Print the list of profile names that can be invoked with the
--profile flag in other skaffold commands.

Use "skaffold <command> --help" for more information about a given command.
❯ skaffold inspect profiles list --help
Print the list of profile names that can be invoked with the --profile flag in
other skaffold commands.

Examples:
  # Get list of profiles
  skaffold inspect profiles list --format json

  # Get list of profiles targeting GoogleCloudBuild environment
  skaffold inspect profiles list --build-env googleCloudBuild --format json

Options:
      --build-env='': If specified as one of "local", "googleCloudBuild" or
"cluster", then filter the output profiles list to that build environment.

Usage:
  skaffold inspect profiles list [flags] [options]

Use "skaffold options" for a list of global command-line options (applies to all
commands).


@gsquared94 gsquared94 requested a review from MarlonGamez May 4, 2021 03:06
@gsquared94 gsquared94 requested a review from a team as a code owner May 4, 2021 03:06
@google-cla google-cla bot added the cla: yes label May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #5778 (e04d763) into master (d14f34d) will decrease coverage by 0.02%.
The diff coverage is 81.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5778      +/-   ##
==========================================
- Coverage   70.78%   70.75%   -0.03%     
==========================================
  Files         432      436       +4     
  Lines       16242    16291      +49     
==========================================
+ Hits        11497    11527      +30     
- Misses       3901     3916      +15     
- Partials      844      848       +4     
Impacted Files Coverage Δ
pkg/skaffold/inspect/types.go 45.45% <45.45%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 92.30% <92.30%> (ø)
cmd/skaffold/app/cmd/inspect.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 87.50% <100.00%> (ø)
pkg/skaffold/inspect/modules.go 100.00% <100.00%> (ø)
pkg/skaffold/inspect/profiles.go 100.00% <100.00%> (ø)
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
pkg/skaffold/build/jib/jvm.go 55.55% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14f34d...e04d763. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼 tested locally and works well

@gsquared94 gsquared94 merged commit 5c3cf22 into GoogleContainerTools:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants