Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make status-check flag nillable #5712

Merged

Conversation

maggieneterval
Copy link
Contributor

Fixes: N/A
Related: #4904
Merge before/after: Merge before #5706

Description
As suggested by @gsquared94 and @MarlonGamez, make the status-check flag nullable in order to distinguish among true, false, and unset values. There is no user-facing impact of this change, but it will enable us to add a new StatusCheck field in the skaffold.yaml (#5706) that, when set to false, will disable the healthcheck when the status-check flag is false or unset.

Follow-up Work (remove if N/A)
Update #5706.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #5712 (bc339e3) into master (46d1c2f) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5712      +/-   ##
==========================================
+ Coverage   70.53%   70.77%   +0.24%     
==========================================
  Files         413      413              
  Lines       15982    16004      +22     
==========================================
+ Hits        11273    11327      +54     
+ Misses       3879     3845      -34     
- Partials      830      832       +2     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.02% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/config/types.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/runcontext/context.go 84.34% <100.00%> (+4.88%) ⬆️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/event/event.go 91.96% <0.00%> (+0.84%) ⬆️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
pkg/skaffold/deploy/status/status_check.go 69.69% <0.00%> (+18.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1c2f...bc339e3. Read the comment docs.

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gsquared94 gsquared94 added kokoro:force-run forces a kokoro re-run on a PR and removed kokoro:force-run forces a kokoro re-run on a PR labels Apr 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 22, 2021
@tejal29 tejal29 merged commit ca4886f into GoogleContainerTools:master Apr 22, 2021
@maggieneterval maggieneterval deleted the nillable-status-check branch April 22, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants