-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make status-check flag nillable #5712
Make status-check flag nillable #5712
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5712 +/- ##
==========================================
+ Coverage 70.53% 70.77% +0.24%
==========================================
Files 413 413
Lines 15982 16004 +22
==========================================
+ Hits 11273 11327 +54
+ Misses 3879 3845 -34
- Partials 830 832 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes: N/A
Related: #4904
Merge before/after: Merge before #5706
Description
As suggested by @gsquared94 and @MarlonGamez, make the
status-check
flag nullable in order to distinguish among true, false, and unset values. There is no user-facing impact of this change, but it will enable us to add a newStatusCheck
field in the skaffold.yaml (#5706) that, when set to false, will disable the healthcheck when thestatus-check
flag is false or unset.Follow-up Work (remove if N/A)
Update #5706.