[V3] New V3 SkaffoldRunner #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
commented
Apr 16, 2021
1. Refactored the runner directory. 2. Create a New SkaffoldRunner for V3. Both runner.SkaffoldRunner and v3.SkaffoldRunner implements the Runner interface. 2. Build, Test, Prune and other shared methods are moved from SkaffoldRunner to several individual structs (BuildRunner, TestRunner). 3. Both SkaffoldRunner and the V3 SkaffoldRunner have the shared structs as components. 4. Unittests are updated. 5. Add placeholders (not implemented error) in v3 SkaffoldRunner for later implementation.
Codecov Report
@@ Coverage Diff @@
## master #5692 +/- ##
==========================================
- Coverage 70.64% 70.48% -0.17%
==========================================
Files 411 421 +10
Lines 15860 16001 +141
==========================================
+ Hits 11205 11279 +74
- Misses 3827 3889 +62
- Partials 828 833 +5
Continue to review full report at Codecov.
|
MarlonGamez
reviewed
Apr 16, 2021
yeah, when changing the schema from v1 to v2, I think we actually should bump the skaffold version to v2 at that time. Do you suggest using v2 here or re-align the schema and master version in this new skaffold render? |
tejal29
suggested changes
Apr 20, 2021
…r.Tester and runner.Pruner
tejal29
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5673
Description