Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #5688

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix typo #5688

merged 1 commit into from
Apr 15, 2021

Conversation

matthewmichihara
Copy link
Contributor

No description provided.

@matthewmichihara matthewmichihara requested a review from a team as a code owner April 15, 2021 14:42
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #5688 (9ab3ead) into master (4e67ac7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5688      +/-   ##
==========================================
+ Coverage   70.64%   70.65%   +0.01%     
==========================================
  Files         411      411              
  Lines       15858    15858              
==========================================
+ Hits        11203    11205       +2     
+ Misses       3827     3826       -1     
+ Partials      828      827       -1
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e67ac7...9ab3ead. Read the comment docs.

MarlonGamez
MarlonGamez approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewmichihara !

@MarlonGamez MarlonGamez merged commit 5edacc9 into master Apr 15, 2021
@nkubala nkubala deleted the matthewmichihara-patch-1 branch September 22, 2021 17:34
@nkubala nkubala restored the matthewmichihara-patch-1 branch September 22, 2021 17:34
@nkubala nkubala deleted the matthewmichihara-patch-1 branch September 22, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonGamez MarlonGamez MarlonGamez approved these changes

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewmichihara @MarlonGamez