Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm render needs to handle repo parameter #5676

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

gsquared94
Copy link
Contributor

Description

skaffold render for helm calls helm template which accepts --repo flag for the chart repository url. This value needs to be set to what is provided in skaffold.yaml.

Testing instruction
In examples/helm-remote-repo, run:

skaffold render --digest-source=none --offline=true

If you don't have the bitnami repo added already (run helm repo ls to check), then it'll fail even though the chart repo is explicitly specified in the skaffold.yaml.

@gsquared94 gsquared94 requested a review from a team as a code owner April 14, 2021 02:41
@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #5676 (b9e7853) into master (1ef4fd8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5676   +/-   ##
=======================================
  Coverage   70.65%   70.66%           
=======================================
  Files         411      411           
  Lines       15793    15796    +3     
=======================================
+ Hits        11159    11162    +3     
  Misses       3813     3813           
  Partials      821      821           
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm/deploy.go 75.82% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef4fd8...b9e7853. Read the comment docs.

@gsquared94 gsquared94 merged commit 0017d8c into GoogleContainerTools:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants