Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputDigest support to CustomTemplateTagger #5661

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

mikekamornikov
Copy link
Contributor

Fixes: #5660
Related: #5192

Description
Allows InputDigest to be added to a map of taggers of CustomTemplateTagger.

@mikekamornikov mikekamornikov requested a review from a team as a code owner April 9, 2021 20:00
@google-cla google-cla bot added the cla: yes label Apr 9, 2021
@mikekamornikov
Copy link
Contributor Author

@piotr-szybicki I'm not sure if it's enough assuming func (t *customTemplateTagger) EvaluateComponents itself makes additions to customMap in the runtime. But this way it creates the tags I expect.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #5661 (93d2e81) into master (89b8315) will increase coverage by 0.13%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5661      +/-   ##
==========================================
+ Coverage   70.53%   70.66%   +0.13%     
==========================================
  Files         410      410              
  Lines       15639    15672      +33     
==========================================
+ Hits        11031    11075      +44     
+ Misses       3794     3784      -10     
+ Partials      814      813       -1     
Impacted Files Coverage Δ
pkg/skaffold/tag/tagger_mux.go 68.96% <80.00%> (+2.29%) ⬆️
pkg/skaffold/docker/parse.go 84.32% <0.00%> (-1.09%) ⬇️
pkg/skaffold/runner/dev.go 72.22% <0.00%> (-0.79%) ⬇️
pkg/skaffold/runner/build_deploy.go 68.68% <0.00%> (-0.21%) ⬇️
pkg/skaffold/event/event.go 91.10% <0.00%> (ø)
pkg/skaffold/errors/errors.go 94.54% <0.00%> (+1.81%) ⬆️
pkg/skaffold/runner/deploy.go 51.35% <0.00%> (+2.05%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️
pkg/skaffold/event/v2/event.go 67.55% <0.00%> (+6.38%) ⬆️
pkg/skaffold/tag/input_digest.go 29.26% <0.00%> (+12.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b8315...93d2e81. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Confirmed working locally. Thanks for taking the time to add this and update tests as well :) I'll merge once kokoro runs

@MarlonGamez MarlonGamez added the kokoro:run runs the kokoro jobs on a PR label Apr 13, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 13, 2021
@tejal29 tejal29 merged commit 132240d into GoogleContainerTools:master Apr 14, 2021
@mikekamornikov mikekamornikov deleted the issue/5660 branch April 15, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputDigest is not supported by CustomTemplateTagger
4 participants