Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service config to leeroy-web deployment.yaml #5630

Conversation

iandanforth-alation
Copy link
Contributor

@iandanforth-alation iandanforth-alation commented Apr 4, 2021

Fixes: #5629

Description
Adds a leeroy-web service of type NodePort to conform with the intent and instructions of the example README.md

User facing changes
Users will now see both a leeroy-web and a leeroy-app service when running the "microservices" example.

@iandanforth-alation iandanforth-alation requested a review from a team as a code owner April 4, 2021 19:37
@google-cla
Copy link

google-cla bot commented Apr 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #5630 (de8f5b9) into master (5757b03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5630   +/-   ##
=======================================
  Coverage   70.71%   70.71%           
=======================================
  Files         408      408           
  Lines       15559    15559           
=======================================
  Hits        11002    11002           
  Misses       3750     3750           
  Partials      807      807           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5757b03...de8f5b9. Read the comment docs.

@iandanforth-alation
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 4, 2021
@MarlonGamez
Copy link
Contributor

hey @iandanforth-alation, thanks for this change! I'll kick off the kokoro run and I think this should be good to merge once it goes green :)

@MarlonGamez MarlonGamez added the kokoro:run runs the kokoro jobs on a PR label Apr 5, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 5, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution :)

@MarlonGamez MarlonGamez merged commit 665b502 into GoogleContainerTools:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microservices example has incorrect config
3 participants