-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service config to leeroy-web deployment.yaml #5630
Add service config to leeroy-web deployment.yaml #5630
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #5630 +/- ##
=======================================
Coverage 70.71% 70.71%
=======================================
Files 408 408
Lines 15559 15559
=======================================
Hits 11002 11002
Misses 3750 3750
Partials 807 807 Continue to review full report at Codecov.
|
@googlebot I signed it! |
hey @iandanforth-alation, thanks for this change! I'll kick off the kokoro run and I think this should be good to merge once it goes green :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the contribution :)
Fixes: #5629
Description
Adds a
leeroy-web
service of type NodePort to conform with the intent and instructions of the example README.mdUser facing changes
Users will now see both a
leeroy-web
and aleeroy-app
service when running the "microservices" example.