[kpt deployer] Fix non-kustomize manifests not rendered issue #5627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5627 +/- ##
==========================================
- Coverage 71.42% 70.53% -0.90%
==========================================
Files 398 410 +12
Lines 14654 15643 +989
==========================================
+ Hits 10467 11034 +567
- Misses 3409 3796 +387
- Partials 778 813 +35
Continue to review full report at Codecov.
|
MarlonGamez
reviewed
Apr 5, 2021
| @@ -312,7 +312,28 @@ func (k *Deployer) renderManifests(ctx context.Context, _ io.Writer, builds []bu | |||
| if err != nil { | |||
| return nil, fmt.Errorf("kustomize build: %w", err) | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
I would add a comment here to just explain why this workaround is needed because I don't think it's super clear what's happening here without context from the github issue/PR
root cause: version changes. kpt-sourced manfiest cannot pipeline directly into the kpt function pipeline. Fix: The sourced manifest is of type "ResourceList" and the raw manifests are stored in the ResourceList.Items.
|
Thanks for the changes, CI flaked on this but I restarted the job. Once it's green I'll go ahead and merge |
MarlonGamez
approved these changes
Apr 8, 2021
|
Thank you @MarlonGamez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5580
Description
root cause: version changes. kpt-sourced manfiest cannot pipeline directly into the kpt function pipeline.
Fix: The sourced manifest is of type "ResourceList" and the raw manifests are stored in the ResourceList.Items.