Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config line number in DEVELOPMENT.md #5619

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

maggieneterval
Copy link
Contributor

Description

Correct pkg/skaffold/schema/latest/config.go comment line number from L25 to L28.

@maggieneterval maggieneterval requested a review from a team as a code owner March 31, 2021 18:28
@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #5619 (aca6509) into master (9edaca4) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5619      +/-   ##
==========================================
+ Coverage   70.83%   70.85%   +0.01%     
==========================================
  Files         404      404              
  Lines       15243    15243              
==========================================
+ Hits        10798    10800       +2     
+ Misses       3647     3646       -1     
+ Partials      798      797       -1     
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 84.32% <0.00%> (-1.09%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edaca4...aca6509. Read the comment docs.

@tejal29 tejal29 merged commit 189a03b into GoogleContainerTools:master Mar 31, 2021
@maggieneterval maggieneterval deleted the doc-fix branch March 31, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants