Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated {{.IMAGES}} and {{.DIGEST_}} env vars #5605

Merged

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Mar 25, 2021

These variables were marked for deprecation well over a year ago - it's time they were removed.

@nkubala nkubala requested a review from a team as a code owner March 25, 2021 21:51
@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #5605 (0e46886) into master (8b4cfda) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5605      +/-   ##
==========================================
- Coverage   71.09%   71.04%   -0.05%     
==========================================
  Files         402      402              
  Lines       15183    15167      -16     
==========================================
- Hits        10794    10776      -18     
- Misses       3596     3597       +1     
- Partials      793      794       +1     
Impacted Files Coverage Δ
pkg/skaffold/build/custom/script.go 51.16% <ø> (-1.11%) ⬇️
pkg/skaffold/tag/tag.go 100.00% <ø> (ø)
pkg/skaffold/tag/env_template.go 100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 85.40% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4cfda...0e46886. Read the comment docs.

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gsquared94 gsquared94 merged commit 834d5ea into GoogleContainerTools:master Mar 29, 2021
@nkubala nkubala deleted the remove-deprecated-vars branch March 30, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants