-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding testing phase to Skaffold run #5594
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5594 +/- ##
==========================================
- Coverage 70.79% 70.78% -0.02%
==========================================
Files 406 406
Lines 15461 15466 +5
==========================================
+ Hits 10946 10947 +1
- Misses 3711 3713 +2
- Partials 804 806 +2
Continue to review full report at Codecov.
|
Does this respect the |
Not now. But can add if the needed. |
Added support for skip-tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please simplify the defer
; otherwise this looks good to go.
Fixes: #5593
Description
Adding testing phase to the Skaffold run
Skaffold run currently has just build & deploy. We need to add test.
PR includes integration tests.
Testing notes
Here are some sample outputs: