Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kubernetes client into its own package #4720

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

gsquared94
Copy link
Contributor

Description
Moved the kubernetes client to its own package. This is a prereq to #4701

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #4720 into master will not change coverage.
The diff coverage is 56.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4720   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files         342      342           
  Lines       13529    13529           
=======================================
  Hits         9934     9934           
  Misses       2976     2976           
  Partials      619      619           
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/kaniko.go 0.00% <0.00%> (ø)
pkg/skaffold/deploy/status_check.go 59.06% <0.00%> (ø)
pkg/skaffold/kubernetes/client/client.go 0.00% <ø> (ø)
pkg/webhook/kubernetes/deployment.go 0.00% <0.00%> (ø)
pkg/webhook/kubernetes/service.go 0.00% <0.00%> (ø)
pkg/skaffold/build/cluster/secret.go 41.53% <50.00%> (ø)
pkg/skaffold/deploy/labels.go 51.28% <100.00%> (ø)
pkg/skaffold/kubernetes/owner.go 87.50% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 70.71% <100.00%> (ø)
...ffold/kubernetes/portforward/resource_forwarder.go 84.31% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241e202...42c8d75. Read the comment docs.

@briandealwis briandealwis changed the title Move kubernetes client into it's own package Move kubernetes client into its own package Aug 26, 2020
@gsquared94 gsquared94 merged commit 27a2d25 into GoogleContainerTools:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants