Handle ctrl-c in the middle of GetAllAuthConfigs() #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4603 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 345 345
Lines 13739 13750 +11
=======================================
+ Hits 10082 10091 +9
- Misses 3023 3025 +2
Partials 634 634
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
ctr-c-auth
branch
2 times, most recently
from
ee43224
to
52a3e29
Compare
Signed-off-by: David Gageot <[email protected]>
gsquared94
approved these changes
Aug 31, 2020
gsquared94
reviewed
Aug 31, 2020
| go func() { | ||
| // Like `docker build`, we ignore the errors | ||
| // See https://github.com/docker/cli/blob/75c1bb1f33d7cedbaf48404597d5bf9818199480/cli/command/image/build.go#L364 | ||
| authConfigs, _ := DefaultAuthHelper.GetAllAuthConfigs() |
There was a problem hiding this comment.
nit: should we pass context into the function DefaultAuthHelper.GetAllAuthConfigs and handle it there?
There was a problem hiding this comment.
I'll do that in another PR. The code is more complicated. But you are right that it makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot [email protected]