Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure log tailing works with pods and deployments #4119

Merged
merged 1 commit into from
May 8, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 6, 2020

Add two integration tests that check the logs

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4119 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@dgageot dgageot force-pushed the add-tail-tests branch 3 times, most recently from 3b7160e to d84cb70 Compare May 7, 2020 15:18
@dgageot dgageot merged commit 58e72a6 into GoogleContainerTools:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants