Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kubernetes to 1.14 and all other k8 deps to 0.17.0 #3938

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Apr 10, 2020

Fixes: Tracking issues that this PR will close
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #3938 into master will not change coverage.
The diff coverage is n/a.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll be requiring kubectl version 1.14 or higher with this right? we'll need to update pkg/skaffold/kubectl/version.go to reflect this. also, we should document that somewhere more visible so it's not as surprising to users.

@balopat balopat self-assigned this Apr 13, 2020
@tejal29
Copy link
Member Author

tejal29 commented Apr 14, 2020

I think we'll be requiring kubectl version 1.14 or higher with this right? we'll need to update pkg/skaffold/kubectl/version.go to reflect this. also, we should document that somewhere more visible so it's not as surprising to users.

I am not sure if we need to do it. The only place kubectl dependency is used is here

tejaldesai@tejaldesai-macbookpro2 skaffold (add_pod_checks)git grep 'k8s.io/kubectl'
cmd/skaffold/app/cmd/cmd.go:    "k8s.io/kubectl/pkg/util/templates"

We are using some util functions from the kubectl package.

@tejal29 tejal29 mentioned this pull request Apr 14, 2020
2 tasks
@nkubala
Copy link
Contributor

nkubala commented Apr 15, 2020

@tejal29 ah yeah you're right, I went ahead and tried this branch out with kubectl 1.12 and everything seems to work fine. I tried to come up with any reasons why we wouldn't want to do this and couldn't, so let's go for it :)

@nkubala nkubala merged commit 3546d95 into GoogleContainerTools:master Apr 15, 2020
@tejal29 tejal29 deleted the bump_k8 branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants