From 2ce5a1927df8e2f7e12fd97d7ebaad9e710f6ebc Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Thu, 4 Apr 2019 15:04:24 -0400 Subject: [PATCH 1/2] Require go >= 1.12 --- DEVELOPMENT.md | 4 ++-- examples/jib/README.adoc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index b4ec50f04f1..195292a93b3 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -9,7 +9,7 @@ This doc explains the development workflow so you can get started You must install these tools: 1. [`go`](https://golang.org/doc/install): The language skaffold is - built in (version >= go 1.11) + built in (version >= go 1.12) 1. [`git`](https://help.github.com/articles/set-up-git/): For source control 1. [`dep`](https://github.com/golang/dep): For managing external Go dependencies. - Please Install dep v0.5.0 or greater. @@ -89,7 +89,7 @@ To build with your local changes you have two options: ``` This will install skaffold via `go install` (note that if you have [manually downloaded - and installed skaffold to `/usr/bin/local`](README.md#installation), this is will probably + and installed skaffold to `/usr/local/bin`](README.md#install), this is will probably take precedence in your path over your `$GOPATH/bin`). _If you are unsure if you are running a released or locally built version of skaffold, you diff --git a/examples/jib/README.adoc b/examples/jib/README.adoc index af6473958a7..7afe6a76fc9 100644 --- a/examples/jib/README.adoc +++ b/examples/jib/README.adoc @@ -2,7 +2,7 @@ :icons: font Jib is one of the supported builders in Skaffold. -[Jib](https://github.com/GoogleContainerTools/jib) builds Docker and OCI images +link:https://github.com/GoogleContainerTools/jib[Jib] builds Docker and OCI images for your Java applications and is available as plugins for Maven and Gradle. The way you configure it in `skaffold.yaml` is the following build stanza: From ae01eb9ebac3a34b05e80a1a1171507b1b846f75 Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Thu, 4 Apr 2019 16:45:17 -0400 Subject: [PATCH 2/2] Revert go 1.12 requirement --- DEVELOPMENT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 195292a93b3..7cd7cf67fe9 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -9,7 +9,7 @@ This doc explains the development workflow so you can get started You must install these tools: 1. [`go`](https://golang.org/doc/install): The language skaffold is - built in (version >= go 1.12) + built in (version >= go 1.11) 1. [`git`](https://help.github.com/articles/set-up-git/): For source control 1. [`dep`](https://github.com/golang/dep): For managing external Go dependencies. - Please Install dep v0.5.0 or greater.