Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker creds) can mount docker config into kaniko pod #1466

Merged
merged 3 commits into from
Jan 17, 2019

Conversation

garethjevans
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #1466 into master will decrease coverage by 0.41%.
The diff coverage is 1.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1466      +/-   ##
=========================================
- Coverage   44.42%     44%   -0.42%     
=========================================
  Files         112     112              
  Lines        4642    4688      +46     
=========================================
+ Hits         2062    2063       +1     
- Misses       2373    2418      +45     
  Partials      207     207
Impacted Files Coverage Δ
pkg/skaffold/build/kaniko/kaniko.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/kaniko/secret.go 0% <0%> (ø) ⬆️
pkg/skaffold/schema/defaults/defaults.go 44.73% <8.33%> (-4.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fdb68b...cfb38b9. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix! Left a couple comments.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Jan 16, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 16, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, just a couple more comments.

Could you also please add these additions to the annotated-skaffold.yaml for documentation? Thanks so much!

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Jan 17, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 17, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for contributing this feature!

@priyawadhwa priyawadhwa merged commit 1310d7d into GoogleContainerTools:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants