-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker creds) can mount docker config into kaniko pod #1466
feat(docker creds) can mount docker config into kaniko pod #1466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
=========================================
- Coverage 44.42% 44% -0.42%
=========================================
Files 112 112
Lines 4642 4688 +46
=========================================
+ Hits 2062 2063 +1
- Misses 2373 2418 +45
Partials 207 207
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this fix! Left a couple comments.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
37efa6b
to
fe7bfc5
Compare
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, just a couple more comments.
Could you also please add these additions to the annotated-skaffold.yaml for documentation? Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for contributing this feature!
No description provided.