Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors hard to find in output #923

Closed
ianlewis opened this issue Aug 23, 2018 · 4 comments
Closed

Compile errors hard to find in output #923

ianlewis opened this issue Aug 23, 2018 · 4 comments

Comments

@ianlewis
Copy link

skaffold dev outputs logs from Pods in the cluster so when updating a service and getting compile errors the errors flow up in the terminal and can be hard to find.

🚀 Moonshot: It would be really cool if you could enter commands into skaffold while it was running to turn off Pod logging dynamically

@dgageot
Copy link
Contributor

dgageot commented Aug 23, 2018

@ianlewis would a mode that stops all the logs until everything is built make sense?
Like you change some code, it triggers a rebuild that fails, il won't print the logs until you fix the issue. I think it could be the default behaviour

dgageot added a commit to dgageot/skaffold that referenced this issue Aug 23, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Aug 23, 2018
@ahmetb
Copy link
Contributor

ahmetb commented Aug 23, 2018

would a mode that stops all the logs until everything is built make sense?

+1 for this. Don't stream logs anymore until all builds are succeeding. It can probably even build something like:

ERROR: docker builds are currently failing for images [gcr.io/foo/bar, gcr.io/foo/quux]

because if service A failed (and I ignored it), then I refactored+saved service B, I can still see service A failing (since this message is printed after every build).

dgageot added a commit to dgageot/skaffold that referenced this issue Aug 23, 2018
@balopat
Copy link
Contributor

balopat commented Aug 23, 2018

I like the idea of stopping the logs too.
We can create a new issue for the interactive skaffold idea (iSkaffold?:)), I think we need more thoughts/design around that, but could be useful for other use cases too? e.g. maybe #913

@ahmetb
Copy link
Contributor

ahmetb commented Aug 23, 2018

Yeah I've been thinking about some interactive terminal where there are multiple panes: One pane I get to uncheck boxes to stop certains services from being watched/logged, another pane that shows build status, another pane shows logs...

I think this is too crazy for now unless we make skaffold binary more modular.

dgageot added a commit to dgageot/skaffold that referenced this issue Aug 24, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Aug 31, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 5, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 6, 2018
atugade pushed a commit to atugade/skaffold that referenced this issue Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants