Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaniko requires a non empty secret name to be set #753

Closed
dgageot opened this issue Jun 27, 2018 · 1 comment
Closed

Kaniko requires a non empty secret name to be set #753

dgageot opened this issue Jun 27, 2018 · 1 comment
Assignees
Labels

Comments

@dgageot
Copy link
Contributor

dgageot commented Jun 27, 2018

skaffold 0.7.0

With this configuration:

apiVersion: skaffold/v1alpha2
kind: Config

build:
  artifacts:
  - imageName: gcr.io/dga-demo/hello
  kaniko:
    namespace: default
    gcsBucket: dga-demo
    pullSecret: ~/secrets/kaniko/dga-demo.json

deploy:
  kubectl:
    manifests:
      - k8s/*.yaml

I get this error:

$ skaffold build -p kaniko
Starting build...
FATA[0002] build step: setting up secret: creating secret: Secret "" is invalid: metadata.name: Required value: name or generateName is required: Secret "" is invalid: metadata.name: Required value: name or generateName is required
@dgageot dgageot added kind/bug Something isn't working area/build build/kaniko labels Jun 27, 2018
@dgageot dgageot self-assigned this Jun 27, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2018
@r2d4 r2d4 closed this as completed in #756 Jun 28, 2018
@lukebond
Copy link

This issue is still present in the current version (0.23.0). If not using GCS or GCR then the secret isn't needed, but you're still required to have it. We work around it by adding a dummy secret (e.g. value = "test"), but it would be nice to be able to drop it altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants