Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user-provided post-renderer for filtering #6951

Closed
briandealwis opened this issue Dec 9, 2021 · 2 comments
Closed

Support user-provided post-renderer for filtering #6951

briandealwis opened this issue Dec 9, 2021 · 2 comments
Assignees
Labels
area/deploy area/render deploy/helm kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Milestone

Comments

@briandealwis
Copy link
Member

Tracking bug: #6706

#6949 changes our Helm deployer to use Skaffold as a post-renderer. This change will break any users that had configured Helm to use their own post-renderer hooks via deploy.helm.flags. We can have skaffold filter support a --post-renderer flag that then invokes the user-configured post-renderer.

@jearangoo
Copy link

jearangoo commented Jul 5, 2023

is there any progress on this?
i am inserting a post renderer in the flags array [ "--post-renderer=./charts/app/kustomizations/dev/render.sh" ] in deploy.helm.flags.install and deploy.helm.flags.upgrade to add patches, secrets and resources like managed google cloud https certificates, to my chart as they vary between environments, when running skaffold run, skaffold dev and skaffold deploy, but its not working with version 2, maybe this should be linked as well #5387?, thanks.

@Agalin
Copy link

Agalin commented Jul 19, 2023

This is a blocker for us, we won't be able to migrate to v2 until a way to run post renderers is added.

We're using them to inject secrets, template stuff outside of Skaffold's and Helm's reach and even pipeline results through kustomize at times.

@ericzzzzzzz ericzzzzzzz added the priority/p1 High impact feature/bug. label Aug 21, 2023
@ericzzzzzzz ericzzzzzzz added this to the v2.8.0 milestone Aug 22, 2023
@ericzzzzzzz ericzzzzzzz self-assigned this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy area/render deploy/helm kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Projects
None yet
Development

No branches or pull requests

5 participants